Introduce SchemaLayout & OperationsLayout #5573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he Gradle plugin, use the primary constructor introduce SchemaLayout & OperationsLayout
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
changed the title
BoD
approved these changes
Jan 29, 2024
libraries/apollo-compiler/src/main/kotlin/com/apollographql/apollo3/compiler/Options.kt
Outdated
Show resolved
Hide resolved
…ollo3/compiler/Options.kt Co-authored-by: Benoit 'BoD' Lubek <BoD@JRAF.org>
martinbonnin
added a commit
that referenced
this pull request
Feb 5, 2024
* add buildCodegenOptions() for times when we want default values. In the Gradle plugin, use the primary constructor introduce SchemaLayout & OperationsLayout * Update libraries/apollo-compiler/src/main/kotlin/com/apollographql/apollo3/compiler/Options.kt Co-authored-by: Benoit 'BoD' Lubek <BoD@JRAF.org> --------- Co-authored-by: Benoit 'BoD' Lubek <BoD@JRAF.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Apologies for the initial title, clicked "submit" a bit too early)
Introduce
SchemaLayoutandOperationsLayoutthat are specialized versions so that someone building the server code doesn't need to specify operations/fragments package names.Also remove default values from options constructors. Given the number of options, it's way too easy to forget passing some. Instead, add
buildFoo()functions that can be used for users of theApolloCompilerAPI