[⚙️compiler] introduce InputFile #5582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
force-pushed
the
04-deprecate-schemaFile-and-sourceFolder
branch
from
06f1d14
to
d4e9944
Compare
martinbonnin
force-pushed
the
05-no-absolute-path-in-ir
branch
from
324f4b1
to
1df0add
Compare
Base automatically changed from
04-deprecate-schemaFile-and-sourceFolder
to
main
January 30, 2024 10:04
martinbonnin
force-pushed
the
05-no-absolute-path-in-ir
branch
from
1df0add
to
bc31dfb
Compare
✅ Deploy Preview for apollo-android-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
packageNamesFromFilePaths()require the normalized path (as in PathSensitivy.RELATIVE normalization) in order to compute the package name.I tried working around this for a while but I came to the conclusion that the proper solution is to make the normalized path a proper input to the compiler. Users that don't need to support
packageNamesFromFilePaths()(like tests) can always usefiles.toInputFiles()to get a list of input files with empty normalized paths.