Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[⚙️compiler] Add KDoc + remove hooks + API tweaks #5591

Merged
merged 8 commits into from
Feb 5, 2024

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Feb 2, 2024

Add KDoc + remove hooks + API tweaks. Especially, add a default implementation for PackageNameGenerator.version and OperationOutputGenerator.version so that implementors do not have to override it.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for apollo-android-docs ready!

Name Link
🔨 Latest commit 0246def
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/65c0f2b13debd80008aebcff
😎 Deploy Preview https://deploy-preview-5591--apollo-android-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@martinbonnin martinbonnin changed the title [⚙️compiler] a few tweaks to [⚙️compiler] Add KDoc + remove hooks + API tweaks Feb 2, 2024
@martinbonnin martinbonnin marked this pull request as ready for review February 2, 2024 18:24
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@martinbonnin martinbonnin requested a review from a team as a code owner February 5, 2024 14:37
@martinbonnin martinbonnin merged commit 6064004 into main Feb 5, 2024
8 of 9 checks passed
@martinbonnin martinbonnin deleted the hide-packagename-generator branch February 5, 2024 14:38
martinbonnin added a commit that referenced this pull request Feb 5, 2024
* add a version of SchemaAndOperationsLayout that doesn't use a PackageNameGenerator

* rename topLevelName to className

* add a default implementation to OperationOutputGenerator.version

* update apiDump

* remove compiler hooks

* add KDoc

* update apiDump

* fix generateMethods KDoc
martinbonnin added a commit that referenced this pull request Feb 27, 2024
* add a version of SchemaAndOperationsLayout that doesn't use a PackageNameGenerator

* rename topLevelName to className

* add a default implementation to OperationOutputGenerator.version

* update apiDump

* remove compiler hooks

* add KDoc

* update apiDump

* fix generateMethods KDoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants