-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler] Add support for @catch on fieldDefinitions, interfaces and objects #5623
Conversation
✅ Deploy Preview for apollo-android-docs canceled.
|
<option name="CALL_PARAMETERS_WRAP" value="0" /> | ||
<option name="CALL_PARAMETERS_LPAREN_ON_NEXT_LINE" value="false" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we need this now. I'm attributing this to latest EAP but something to keep an eye on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Ping @rohandhruva . If everything goes well, this should end up in the SNAPSHOTs soon. |
Thank you so much, I'll keep an eye out for it! |
Implementation of apollographql/specs#48
See apollographql/specs#47
@catch
can now be set, by order or precedence:At the schema level
At the field definition level
At the field level
Also took this opportunity to factor in the
@semanticNonNullField
handling in schema merging so that it's done in a central place.