Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐘 gradle-plugin] Use Gradle normalization instead of ours #5636

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Feb 21, 2024

We don't need internal sourceRoots as FileCollection rightfully includes the normalized path.

This simplifies the code quite a bunch but is unfortunately blocked on gradle/gradle#28147 (edit found a workaround)

This is a behaviour change for users using both packageNameFromFilePaths and schemaFile that can be mitigated by using schemaFiles instead:

    packageNameFromFilePaths()

    // replace
    schemaFile.set("src/main/graphql/com/example/schema.graphqls")

    // with
    schemaFiles.from(fileTree("src/main/graphql/").apply {
      include("com/example/schema.graphqls")
    })

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 3412a6e
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/65ddb60ba5829c00084546be

@martinbonnin martinbonnin marked this pull request as ready for review February 27, 2024 10:14
@martinbonnin
Copy link
Contributor Author

I found a workaround

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@martinbonnin martinbonnin merged commit fd16cc0 into main Feb 27, 2024
9 checks passed
@martinbonnin martinbonnin deleted the remove-normalize branch February 27, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants