-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup ApolloClient.Builder #5683
Conversation
✅ Deploy Preview for apollo-android-docs canceled.
|
public final fun httpExposeErrorBody (Z)Lcom/apollographql/apollo3/ApolloClient$Builder; | ||
public final fun httpExposeErrorBody (Ljava/lang/Boolean;)Lcom/apollographql/apollo3/ApolloClient$Builder; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking ABI change because the parameter is now nullable.
public synthetic fun <init> (Lcom/apollographql/apollo3/network/NetworkTransport;Lcom/apollographql/apollo3/api/CustomScalarAdapters;Lcom/apollographql/apollo3/network/NetworkTransport;Ljava/util/List;Lcom/apollographql/apollo3/api/ExecutionContext;Lkotlinx/coroutines/CoroutineDispatcher;Lcom/apollographql/apollo3/api/http/HttpMethod;Ljava/util/List;Ljava/lang/Boolean;Ljava/lang/Boolean;Ljava/lang/Boolean;Ljava/lang/Boolean;Lcom/apollographql/apollo3/ApolloClient$Builder;Lkotlin/jvm/internal/DefaultConstructorMarker;)V | ||
public synthetic fun <init> (Lcom/apollographql/apollo3/ApolloClient$Builder;Lkotlin/jvm/internal/DefaultConstructorMarker;)V |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is implementation detail => not breaking
ad2ce13
to
13c3518
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚙️
Prep work for adding more retry related things in
ApolloClient.Builder
.This PR:
networkTransport
/subscriptionNetworkTransport
creation and checks toApolloClient
.Builder
functions accept a nullable value to reset the parameter (and consistency as well).ApolloClient
its own copy ofBuilder
(never mutated)The previous code was problematic in cases like this:
See also #3759