Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IJ Plugin] Consider all Gradle projects recursively #5734

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Mar 18, 2024

Apollo modules were not found if they were nested more than 1 level deep (e.g. :shared:data).

Also, use the path instead of the name everywhere (a tad involved because of versioning).

Screenshot 2024-03-18 at 11 47 40

Here we see the Graphql project is now named shared-data/service vs data/service previously (could be a problem if several subprojects are named data).

@BoD BoD requested a review from martinbonnin as a code owner March 18, 2024 11:02
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 97a59ee
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/65f8223142d8900008bf5128

@BoD BoD merged commit a1fba22 into main Mar 18, 2024
9 checks passed
@BoD BoD deleted the ij-plugin-fix-apollo-project-not-found branch March 18, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants