[🗄️ cache] Make ApolloStore.publish() suspend #5755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
commented
Mar 21, 2024
Comment on lines
+342
to
+343
| // Because subscribe is called from a background thread, give some time to be effective | ||
| delay(500) |
There was a problem hiding this comment.
That's an interesting one. If we want a guarantee that .watch() subscribes synchronously, we probably need to go back to "interceptors do their own dispatcher switch". I want to measure how costly the thread switch is.
BoD
approved these changes
Mar 22, 2024
Comment on lines
87
to
88
| * Write an operation data to the store and optionally publish changes of [Record] which have changed, | ||
| * that will notify any watcher that depends on these [Record] to re-fetch. |
There was a problem hiding this comment.
Suggested change
| * Write an operation data to the store and optionally publish changes of [Record] which have changed, | |
| * that will notify any watcher that depends on these [Record] to re-fetch. | |
| * Write an operation data to the store. |
Or maybe do we want to highlight it a bit more?
Suggested change
| * Write an operation data to the store and optionally publish changes of [Record] which have changed, | |
| * that will notify any watcher that depends on these [Record] to re-fetch. | |
| * Write an operation data to the store. Call [publish] with the returned keys to notify any watcher that depends on these [Record] to re-fetch. |
(same for writeFragment)
There was a problem hiding this comment.
Good call out. I added a @see publish tag so hopefully it should be enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made
publishsuspend so that the cache writers wait for the readers and no cache key event is lost. The buffer of size 64 is still there to smooth things out.Incubating cache gets removed
publishparameter.Stable cache gets overloads
writeFoo()functions. The ones with apublishparameter should probably be deprecated but I'm not 100% sure yet.Next steps:
watch()return aFusibleFlowso that the user has control of the buffering there.ApolloStore.writeFoo(publish)See #3920