Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🏃runtime] Merge incubating WebSockets in apollo-runtime #5790

Merged
merged 8 commits into from
Apr 10, 2024
Merged

[🏃runtime] Merge incubating WebSockets in apollo-runtime #5790

merged 8 commits into from
Apr 10, 2024

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Apr 9, 2024 •
edited
Loading

  • move to package .websocket
  • merge into apollo-runtime
  • make everything @ApolloExperimental
  • remove duplicate websockets package

Next:

  • use .websocket in tests
  • write documentation

@martinbonnin martinbonnin requested a review from BoD as a code owner April 9, 2024 14:46
@netlify Netlify
Copy link

netlify bot commented Apr 9, 2024 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit b3893b5
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/661595d03ed79f00087b047b

BoD
BoD approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🧦

@martinbonnin martinbonnin merged commit 2004d90 into main Apr 10, 2024
9 checks passed
@martinbonnin martinbonnin deleted the merge-incubating branch April 10, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinbonnin @BoD