Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support Kotlin/Wasm for apollo-adapters #5803

Merged
merged 2 commits into from
Apr 15, 2024
Merged

support Kotlin/Wasm for apollo-adapters #5803

merged 2 commits into from
Apr 15, 2024

Conversation

joreilly
Copy link
Contributor

@joreilly joreilly commented Apr 12, 2024 •
edited
Loading

addresses #5795

@apollo-cla
Copy link

@joreilly: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@netlify Netlify
Copy link

netlify bot commented Apr 12, 2024 •
edited
Loading

👷 Deploy request for apollo-android-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a482b0d

martinbonnin
martinbonnin reviewed Apr 12, 2024
View reviewed changes
Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

...llo-adapters/src/wasmJsTest/kotlin/com/apollographql/apollo3/adapter/test/BigDecimalTests.kt Outdated
import com.apollographql.apollo3.adapter.BigDecimal
import kotlin.test.*

class BigDecimalTests {
Copy link
Contributor

@martinbonnin martinbonnin Apr 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those the exact same tests as for JS? If yes, I'll try to factor them in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, was wondering about that too (they are identical)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try. Also, I wonder why they are jsTest and not commonTest, I'll dig

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a commit to share the tests between JS and Wasm.

I tried moving to commonTest. Unfortunately, we still have behavioural discrepencies there :/...We should probably use a proper BigDecimal lib. Anyone with recommendations?

@martinbonnin martinbonnin merged commit a5f3d9e into apollographql:main Apr 15, 2024
5 checks passed
@martinbonnin
Copy link
Contributor

Thanks!

@martinbonnin martinbonnin mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbonnin martinbonnin martinbonnin left review comments

@BoD BoD Awaiting requested review from BoD BoD is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joreilly @apollo-cla @martinbonnin