Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better messages and debuggability for ApolloCompilerPlugin #5821

Merged
merged 7 commits into from
Apr 17, 2024
Merged

Better messages and debuggability for ApolloCompilerPlugin #5821

merged 7 commits into from
Apr 17, 2024

Conversation

martinbonnin
Copy link
Contributor

  • fails if plugin() and packageNameGenerator/operationOutputGenerator/operationIdGenerator are set at the same time
  • renames Plugin -> ApolloCompilerPlugin
  • add links to https://go.apollo.dev/ak-compiler-plugins

@martinbonnin martinbonnin requested a review from BoD as a code owner April 16, 2024 21:20
@netlify Netlify
Copy link

netlify bot commented Apr 16, 2024 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit e0c69d1
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/661f8a929262eb0008d8bc31

BoD
BoD approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

...e-plugin-external/src/main/kotlin/com/apollographql/apollo3/gradle/internal/serviceloader.kt Outdated Show resolved Hide resolved
@martinbonnin @BoD
Update libraries/apollo-gradle-plugin-external/src/main/kotlin/com/ap…
e0c69d1 
…ollographql/apollo3/gradle/internal/serviceloader.kt

Co-authored-by: Benoit 'BoD' Lubek <BoD@JRAF.org>
@martinbonnin martinbonnin merged commit 02dbe74 into main Apr 17, 2024
9 checks passed
@martinbonnin martinbonnin deleted the better-messages branch April 17, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinbonnin @BoD