[IJ Plugin] Add inspection to warn about the presence of a GraphQL config file #5908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
BoD
changed the title
| groupKey="inspection.group.graphql.apolloKotlin" | ||
| key="inspection.graphQLConfigFilePresent.displayName" | ||
| enabledByDefault="true" | ||
| level="ERROR" |
There was a problem hiding this comment.
If it is not needed but doesn't harm it should be a warning.
Suggestion:
Apollo Kotlin 4 uses the Gradle tooling API to retrieve the GraphQL configuration and doesn't use the GraphQL config file.
If it's an actual error, ERROR is fine of course but sounds like there is a disconnect between the message and the level here.
BoD
force-pushed
the
ij-plugin-graphqlconfig-file-present
branch
from
829964e
to
c525036
Compare
BoD
force-pushed
the
ij-plugin-graphqlconfig-file-present
branch
from
c525036
to
88a4f66
Compare
BoD
force-pushed
the
ij-plugin-graphqlconfig-file-present
branch
from
88a4f66
to
91dd7e6
Compare
intellij-plugin/src/main/resources/inspectionDescriptions/ApolloGraphQLConfigFilePresent.html
Outdated
Show resolved
Hide resolved
…loGraphQLConfigFilePresent.html Co-authored-by: Martin Bonnin <martin@mbonnin.net>
martinbonnin
approved these changes
May 29, 2024
BoD
added a commit
to BoD/apollo-kotlin
that referenced
this pull request
Jul 1, 2024
…nfig file (apollographql#5908) * Add inspection to warn about the presence of a GraphQL config file * Add v3 -> v4 migration to delete GraphQL config files * Add tests * Tweak wording * Change severity to warning and tweak messages * Fix test * Update intellij-plugin/src/main/resources/inspectionDescriptions/ApolloGraphQLConfigFilePresent.html Co-authored-by: Martin Bonnin <martin@mbonnin.net> --------- Co-authored-by: Martin Bonnin <martin@mbonnin.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove GraphQL config files when migrating v3 -> v4.
Fix for #5887