[testing] Simplify our implementation of runTest #5935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
force-pushed
the
remove-run-test
branch
from
75fc316 to
f36867e
Compare
✅ Deploy Preview for apollo-android-docs canceled.
|
BoD
pushed a commit
to BoD/apollo-kotlin
that referenced
this pull request
Jul 1, 2024
* remove our own implementation of runTest * make sure to close the connection at the end of the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use
kotlinx.coroutines.test.runTest {}as underlying mechanism for our tests. This removes our K2 workaround and simplifies the setup a bunch.Our own
runTest {}is still there for:before/aftercallbacks which we should probably remove at some point. I started doing it but we have a loooooot of tests and ultimately gave up. Will refactor them progressively.