Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CacheKeyApolloResolver based on ApolloResolver (incubating) #5970

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Jun 14, 2024

Related to #5964.

Also tweaked the doc/kdoc a little bit.

@BoD BoD requested review from a team and martinbonnin as code owners June 14, 2024 15:10
Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for apollo-android-docs ready!

Name Link
🔨 Latest commit c825b4f
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/666c5d5992bcff00082f3eb9
😎 Deploy Preview https://deploy-preview-5970--apollo-android-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my I forgot we had both ApolloResolver and CacheResolver... This is becoming quite hairy but besides that, LGTM

@BoD
Copy link
Contributor Author

BoD commented Jun 14, 2024

Oh my I forgot we had both ApolloResolver and CacheResolver... This is becoming quite hairy

Yeah 😅 It will probably make sense to break compatibility at some near point and when that comes, we can keep only one of them.

@martinbonnin
Copy link
Contributor

Yea, it's -incubating + @ApolloExperimental. At some point it's too much detail.

@BoD BoD merged commit 720d01d into main Jun 14, 2024
9 checks passed
@BoD BoD deleted the apollo-key-resolver branch June 14, 2024 16:39
BoD added a commit to BoD/apollo-kotlin that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants