Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup mpp utils #5980

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Cleanup mpp utils #5980

merged 5 commits into from
Jun 20, 2024

Conversation

martinbonnin
Copy link
Contributor

  • replace currentTimeMillis() with markNow() where possible.
  • move platform() and currentThreadId() to apollo-testing-support.

apollo-mpp-utils now only contains currentTimeMillis() that we should probably remove from HttpInfos

@martinbonnin martinbonnin requested a review from BoD as a code owner June 18, 2024 11:00
@netlify Netlify
Copy link

netlify bot commented Jun 18, 2024 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit cd15388
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/66716ace95e191000876fa7d

BoD
BoD approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit 99e227b into main Jun 20, 2024
9 checks passed
@martinbonnin martinbonnin deleted the cleanup-mpp-utils branch June 20, 2024 07:42
BoD pushed a commit to BoD/apollo-kotlin that referenced this pull request Jul 1, 2024
@martinbonnin @BoD
Cleanup mpp utils (apollographql#5980)
015efcb 
* replace currentTimeMillis -> TimeMark

* cleanup mpp-utils

* move platform() to testing-support

* make compile

* fix coroutines test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinbonnin @BoD