Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

@apollo/client integration #1158

Closed
wants to merge 31 commits into from
Closed

@apollo/client integration #1158

wants to merge 31 commits into from

Conversation

hwillson
Copy link
Member

@hwillson hwillson commented Oct 3, 2019

Core Apollo Link functionality is being merged into Apollo Client 3. This PR removes the functionality that is going to be part of Apollo Client 3, and updates the remaining packages to include the common functionality they need from @apollo/client.

Related:

@hwillson
Copy link
Member Author

hwillson commented Oct 3, 2019

Note - tests here will fail until @apollo/client@3.0.0-alpha.7 is published.

@hwillson hwillson mentioned this pull request Oct 4, 2019
Merged
@kamilkisiela
Copy link
Contributor

Could we merge apollographql/apollo-client#5541 and use @apollo/client/common? Otherwise apollo-link and every apollo-link-* package will break UI integrations other than React.

@hwillson hwillson self-assigned this Nov 6, 2019
@hwillson hwillson added this to the Apollo Client 3.0 Launch milestone Nov 6, 2019
@GoranZic GoranZic mentioned this pull request Nov 12, 2019
Closed
@codecov-io
Copy link

codecov-io commented Nov 15, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@482fb3e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1158   +/-   ##
=========================================
  Coverage          ?   95.46%           
=========================================
  Files             ?       12           
  Lines             ?      353           
  Branches          ?       87           
=========================================
  Hits              ?      337           
  Misses            ?       16           
  Partials          ?        0
Impacted Files Coverage Δ
...ckages/apollo-link-batch-http/src/batchHttpLink.ts 90.62% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482fb3e...faf1193. Read the comment docs.

@hwillson
Remove packages that are now available from @apollo/client
871e8db 
Removes:

- apollo-link
- apollo-link-http-common
- apollo-link-http
@hwillson
Adjust all packages to use common link code from @apollo/client
65f15d4 
@apollo/client is now a dependency of all Apollo Link packages.
This commit adjusts the remaining Apollo Link packages to
leverage the common link code now bundled into @apollo/client.
@hwillson
Replicate test utilities from @apollo/client to reduce exports
7255594 
These are only be used by this test, so we'll create a copy of
them here to stop re-exporting them from `@apollo/client`.
@hwillson
Remove the apollo-link-dedup package
a44f9d3 
Link deduplication now happens automatically in Apollo Client.
@hwillson
Remove docs since they're going to be part of the AC 3 docs
0c9abed
@hwillson
Bump to most recent @apollo/client beta
e06572d
@hwillson
Add breaking entries to the changelog
a13373c
@hwillson
Stop mixing named and default exports from packages
761d82c
@hwillson
Replace apollo-link reference with @apollo/client
1bf9f23
@hwillson
Exclude @apollo/client and graphql-tag from bundles
a26e20c
@hwillson
Start tracking package lock
e8f29f7
@hwillson
Update to use @apollo/client/core
0f9fc8b 
(which isn't available yet but will be soon)
@hwillson
Bump to latest @apollo/client beta
fcc254a
@hwillson
Rollup bundle size tweaks
aaa89d5
@hwillson hwillson force-pushed the apollo-client-integration branch from 38d79c3 to aaa89d5 Compare November 15, 2019 19:46
@hwillson
Prep for beta publish
114acff
@hwillson
Lerna package lock updates
8eb8e52
@hwillson
chore: Publish
150213d 
 - apollo-link-batch-http@2.0.0-beta.0
 - apollo-link-batch@2.0.0-beta.0
 - apollo-link-context@2.0.0-beta.0
 - apollo-link-error@2.0.0-beta.0
 - apollo-link-polling@2.0.0-beta.0
 - apollo-link-retry@3.0.0-beta.0
 - apollo-link-schema@2.0.0-beta.0
 - apollo-link-ws@2.0.0-beta.0
 - zen-observable-ts@1.0.0-beta.0
@hwillson
Copy link
Member Author

hwillson commented Nov 15, 2019 •
edited
Loading

The following beta Links are now published and ready for testing:

  • apollo-link-batch-http@2.0.0-beta.0
  • apollo-link-batch@2.0.0-beta.0
  • apollo-link-context@2.0.0-beta.0
  • apollo-link-error@2.0.0-beta.0
  • apollo-link-retry@3.0.0-beta.0
  • apollo-link-schema@2.0.0-beta.0
  • apollo-link-ws@2.0.0-beta.0

These have a dependency on @apollo/client@beta. Note that the docs will continue to fail here until we remove the Netlify job completely (which will happen when @apollo/client is launched).

@hwillson hwillson removed their assignment Dec 24, 2019
@TamerShlash TamerShlash mentioned this pull request Jan 10, 2020
Closed
@hwillson
Package lock updates
ab2b623
@hwillson
Re-add package locks to github to make lerna happy
5e3ba7d
@hwillson
chore: Publish
f3df894 
 - @apollo/link-batch-http@2.0.0-beta.2
 - @apollo/link-batch@2.0.0-beta.2
 - @apollo/link-context@2.0.0-beta.2
 - @apollo/link-error@2.0.0-beta.2
 - @apollo/link-polling@2.0.0-beta.2
 - @apollo/link-retry@2.0.0-beta.2
 - @apollo/link-schema@2.0.0-beta.2
 - @apollo/link-ws@2.0.0-beta.2
 - zen-observable-ts@1.0.0-beta.2
@hwillson
Adjustments needed to publish scaped packages with lerna
0d0cc87 
Ref: https://github.com/lerna/lerna/tree/master/commands/publish#publishconfigaccess
@hwillson
chore: Publish
faf1193 
 - @apollo/link-batch-http@2.0.0-beta.3
 - @apollo/link-batch@2.0.0-beta.3
 - @apollo/link-context@2.0.0-beta.3
 - @apollo/link-error@2.0.0-beta.3
 - @apollo/link-polling@2.0.0-beta.3
 - @apollo/link-retry@2.0.0-beta.3
 - @apollo/link-schema@2.0.0-beta.3
 - @apollo/link-ws@2.0.0-beta.3
@vvakame vvakame mentioned this pull request Jun 29, 2020
Open
@vvakame
Copy link

vvakame commented Jun 29, 2020

@hwillson could you publish with @apollo/client RC version?

@hwillson
Copy link
Member Author

We've decided to move the rest of the links in this repo over to the Apollo Client repo (details: apollographql/apollo-client#6577).

@hwillson hwillson closed this Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjamn benjamn Awaiting requested review from benjamn

@jbaxleyiii jbaxleyiii Awaiting requested review from jbaxleyiii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Apollo Client 3.0 Launch
Development

Successfully merging this pull request may close these issues.
4 participants
@hwillson @kamilkisiela @codecov-io @vvakame