Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow built-in directives to be redefined #684

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

SimonSapin
Copy link
Contributor

Fixes #656

# [x.x.x] (unreleased) - 2023-mm-dd

## Features
- Add `validate_standalone_executable` function to validate an executable document without access to a schema, by [goto-bus-stop] in [pull/631], [issue/629]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was commented out for some reason, but it’s a real feature that was added in 0.11.2

Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for us to continue switching the router to rust-only validation, this will also have to be backported to the 0.11.x branch 😅

@SimonSapin
Copy link
Contributor Author

The relevant code is completely different so that will have to be a manual backport

@SimonSapin SimonSapin merged commit dd263f1 into compiler-v1.0 Oct 9, 2023
9 checks passed
@SimonSapin SimonSapin deleted the built-in-directive-redefinition branch October 9, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants