Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Directives and Diagnostics to DirectiveList and DiagnosticsList #732

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

SimonSapin
Copy link
Contributor

Fixes #711

The previous names were too similar to Directive and Diagnostic (singular).

…ticsList`

Fixes #711

The previous names were too similar to `Directive` and `Diagnostic` (singular).
crates/apollo-compiler/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Renée <renee@kooi.me>
@SimonSapin SimonSapin enabled auto-merge (squash) November 9, 2023 13:11
@SimonSapin SimonSapin merged commit 074d599 into main Nov 9, 2023
9 of 10 checks passed
@SimonSapin SimonSapin deleted the list branch November 9, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnostic and Diagnostics are very similar names
2 participants