Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper features for Name and Type #739

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Helper features for Name and Type #739

merged 4 commits into from
Nov 14, 2023

Conversation

SimonSapin
Copy link
Contributor

No description provided.

@SimonSapin SimonSapin self-assigned this Nov 13, 2023
goto-bus-stop
goto-bus-stop approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

@SimonSapin
Copy link
Contributor Author

CI fails on macOS 🤔

error: failed to run custom build command for `libfuzzer-sys v0.4.7`
[…]
  cargo:warning=libfuzzer/FuzzerDefs.h:14:10: fatal error: 'cassert' file not found
[…]
  error occurred: Command "c++" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-gdwarf-2" "-fno-omit-frame-pointer" "-m64" "--target=x86_64-apple-darwin" "-mmacosx-version-min=10.7" "-Wall" "-Wextra" "-std=c++17" "-fno-omit-frame-pointer" "-w" "-o" "/Users/distiller/project/target/debug/build/libfuzzer-sys-82fe81b55dd69567/out/libfuzzer/FuzzerTracePC.o" "-c" "libfuzzer/FuzzerTracePC.cpp" with args "c++" did not execute successfully (status code exit status: 1).

@SimonSapin SimonSapin mentioned this pull request Nov 13, 2023
Closed
@SimonSapin
Copy link
Contributor Author

This also happens on main: #740

@SimonSapin SimonSapin merged commit ed0d481 into main Nov 14, 2023
11 checks passed
@SimonSapin SimonSapin deleted the name branch November 14, 2023 09:47
@goto-bus-stop goto-bus-stop mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goto-bus-stop goto-bus-stop goto-bus-stop approved these changes

@lrlna lrlna Awaiting requested review from lrlna lrlna is a code owner

Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonSapin @goto-bus-stop