Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted API tweaks + prepare apollo_compiler@1.0.0 beta.19 #885

Merged
merged 14 commits into from
Jul 19, 2024
Merged

Assorted API tweaks + prepare apollo_compiler@1.0.0 beta.19 #885

merged 14 commits into from
Jul 19, 2024

Conversation

SimonSapin
Copy link
Contributor

@SimonSapin SimonSapin commented Jul 19, 2024 •
edited
Loading

Moved from the crate root to the new(ly public) apollo_compiler::parser module:

  • Parser
  • SourceFile
  • SourceMap
  • FileId

Moved to the parser module and renamed:

  • NodeLocation → SourceSpan
  • GraphQLLocation → LineColumn

Added a few helper methods:

  • executable::OperationMap::from_one
  • schema::SchemaDefinition::iter_root_operations
  • schema::ExtendedType::is_leaf

@SimonSapin
Copy link
Contributor Author

New crate root:
image

parser module:
image

@SimonSapin SimonSapin merged commit 13f4aa1 into main Jul 19, 2024
12 checks passed
@SimonSapin SimonSapin deleted the apollo-compiler@1.0.0-beta.19 branch July 19, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goto-bus-stop goto-bus-stop goto-bus-stop left review comments

@lrlna lrlna lrlna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonSapin @goto-bus-stop @lrlna