chore(compiler): make unused variable validation more efficient #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation used a hash map and two hash sets. We can do the exact same validation with only a hash map, by first putting all declared variables in the hash map, and removing variables as we see them used. Then at the end we only have unused variables in the map.
lrlna
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small thing I was doing for #883 but we merged that early ;)
The validation used a hash map and two hash sets. We can do the exact same validation with only a hash map, by first putting all declared variables in the hash map, and removing variables as we see them used. Then at the end we only have unused variables in the map.