Skip to content

Commit

Permalink
Revert noLocation:true as default, but preserve parseOptions.
Browse files Browse the repository at this point in the history
Thanks to @abernix for his thoughtful objections in this comment:
#2289 (review)
  • Loading branch information
benjamn committed Feb 12, 2019
1 parent ccff9c3 commit 06459a1
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions packages/apollo-server-core/src/ApolloServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -293,14 +293,7 @@ export class ApolloServerBase {
typeDefs: augmentedTypeDefs,
schemaDirectives,
resolvers,
parseOptions: {
// Since ApolloServer does not use the location/token information the
// graphql/language/parser attaches to the schema, we can save some
// memory (and potentially some parsing time) with this default.
noLocation: true,
// Other options can be passed into the ApolloServerBase constructor.
...parseOptions,
},
parseOptions,
});
}

Expand Down

0 comments on commit 06459a1

Please sign in to comment.