Skip to content

Commit

Permalink
Docs follow-up from #6936
Browse files Browse the repository at this point in the history
- A bit more clarity about batching and HTTP headers in one place; not
  even bothering in another place (it seems a bit specific for the
  options reference, which links to the first place anyway)
- Revert accidental change to AS3 example
  • Loading branch information
glasser committed Sep 26, 2022
1 parent 0ddf04f commit 5360f5f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
2 changes: 0 additions & 2 deletions docs/source/api/apollo-server.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,6 @@ An object containing configuration options for connecting Apollo Server to [Apol

Controls whether to allow [Batching Queries](../workflow/requests/#batching) in a single HTTP Request. Defaults to `false`. If a request comes in formatted as an array rather than as a single request object, an error will be thrown ( i.e., `Operation batching disabled`) _unless_ batching is enabled.

> Note: In the case of duplicate response headers across separate requests, the later request's header will take precedence on a per-header basis.
</td>
</tr>

Expand Down
8 changes: 3 additions & 5 deletions docs/source/migration.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -1134,11 +1134,9 @@ const result = await server.executeOperation({
query: 'query helloContext { hello }',
}, {
// highlight-start
contextValue: {
// A half-hearted attempt at making something vaguely like an express.Request,
// and not bothering to make the express.Response at all.
req: { headers: { name: 'world' } },
}
// A half-hearted attempt at making something vaguely like an express.Request,
// and not bothering to make the express.Response at all.
req: { headers: { name: 'world' } },
// highlight-end
});

Expand Down
2 changes: 1 addition & 1 deletion docs/source/workflow/requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ If you have enabled HTTP batching, you can send a batch of queries in a single `

If you send a batched request, Apollo Server responds with a corresponding array of GraphQL responses.

> Note: In the case of duplicate response headers across separate requests, the later request's header will take precedence on a per-header basis.
> Note: If multiple operations in a request try to set the same HTTP response header ([via error extensions or plugins](../data/errors#setting-http-status-code-and-headers), headers from later operations will take precedence on a per-header basis.
## GET requests

Expand Down

0 comments on commit 5360f5f

Please sign in to comment.