Skip to content

Commit

Permalink
test: fix failing integration tests on node@18 (#6350)
Browse files Browse the repository at this point in the history
  • Loading branch information
IvanGoncharov authored Apr 28, 2022
1 parent baaac91 commit 6cd417c
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ workflows:
node-version:
- "14"
- "16"
- "17"
- "18"
- "Check for FIXM\x45"
- Prettier
- Spell check
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
},
"dependencies": {
"@apollo/usage-reporting-protobuf": "^3.3.0",
"@apollo/utils.createhash": "^1.0.0",
"@apollo/utils.isnodelike": "^1.0.0",
"@apollo/utils.createhash": "^1.1.0",
"@apollo/utils.isnodelike": "^1.1.0",
"@apollo/utils.logger": "^1.0.0",
"@apollo/utils.fetcher": "^1.0.0",
"@apollographql/graphql-playground-html": "1.6.29",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -934,7 +934,8 @@ export function defineIntegrationTestSuiteApolloServerTests(
const { family, address, port } =
this.server.address() as AddressInfo;

if (family !== 'IPv4') {
// @ts-expect-error until https://github.com/DefinitelyTyped/DefinitelyTyped/pull/60042
if (family !== 'IPv4' && family !== 4) {
throw new Error(`The family was unexpectedly ${family}.`);
}
return new URL(`http://${address}:${port}`).toString();
Expand Down Expand Up @@ -1959,7 +1960,8 @@ export function defineIntegrationTestSuiteApolloServerTests(

const { family, address, port } =
fakeUsageReportingServer.address() as AddressInfo;
if (family !== 'IPv4') {
// @ts-expect-error until https://github.com/DefinitelyTyped/DefinitelyTyped/pull/60042
if (family !== 'IPv4' && family !== 4) {
throw new Error(`The family was unexpectedly ${family}.`);
}

Expand Down

0 comments on commit 6cd417c

Please sign in to comment.