chore(op-reg): Change to Logger types from apollo-server-types fo…

…r agent.

Use the `Logger` types which are now provided by `apollo-server-types` as a
base type for a "logger" now, introduced in the below-referenced PR.

Note: While it's now more within reach, this doesn't yet expose the `logger`
configurability at the top-level, nor does it try to leverage the `logger`
that is provided to `serverWillStart` since that will require additional
changes which are currently out of scope to accommodate the `dryRun` mode of
operation which currently forces the log-level to a specific level when
activated. Further, it does so using a `loglevel`-specific API.

Therefore, these changes are best described as being limited to the agent's
logger.

[Ref]: #3894

packages/apollo-server-plugin-operation-registry/src/__tests__/agent.test.ts

@@ -20,6 +20,7 @@ import {
 import Agent, { AgentOptions } from "../agent";
 import { Operation, OperationManifest } from "../ApolloServerPluginOperationRegistry";
 import { fakeTestBaseUrl, getLegacyOperationManifestUrl, getStoreKey, getOperationManifestUrl, urlOperationManifestBase } from "../common";
+import { Logger } from "apollo-server-types";
 
 // These get a bit verbose within the tests below, so we use this as a
 // sample store to pick and grab from.
@@ -148,7 +149,7 @@ describe('Agent', () => {
           sampleManifestRecords.c,
         ]);
         const relevantLogs: any = [];
-        const logger = {
+        const logger: Logger = {
           debug: jest.fn().mockImplementation((...args: any[]) => {
             if (
               typeof args[0] === 'string' &&
@@ -167,6 +168,8 @@ describe('Agent', () => {
               relevantLogs.push(args);
             }
           }),
+          info: () => {},
+          error: () => {},
         };
         await createAgent({ logger }).start();
 

packages/apollo-server-plugin-operation-registry/src/agent.ts

@@ -13,12 +13,13 @@ import { Response } from 'node-fetch';
 import { InMemoryLRUCache } from 'apollo-server-caching';
 import { fetchIfNoneMatch } from './fetchIfNoneMatch';
 import { OperationManifest } from "./ApolloServerPluginOperationRegistry";
+import { Logger } from "apollo-server-types";
 
 const DEFAULT_POLL_SECONDS: number = 30;
 const SYNC_WARN_TIME_SECONDS: number = 60;
 
 export interface AgentOptions {
-  logger?: loglevel.Logger;
+  logger?: Logger;
   pollSeconds?: number;
   schemaHash: string;
   engine: any;
@@ -32,7 +33,7 @@ const callToAction = `Ensure this server's schema has been published with 'apoll
 
 export default class Agent {
   private timer?: NodeJS.Timer;
-  private logger: loglevel.Logger;
+  private logger: Logger;
   private hashedServiceId?: string;
   private requestInFlight: Promise<any> | null = null;
   private lastSuccessfulCheck?: Date;