Skip to content

Commit

Permalink
apollo-server-plugin-base: ApolloServerPlugin isn't AnyFunctionMap
Browse files Browse the repository at this point in the history
This `extends` declaration was added during the development of v2.18.0 for
reasons that turned out to be unnecessary. The declaration makes some
valid plugin implementation no longer type-check, so I'm removing it.

Fixes #4585.
  • Loading branch information
glasser committed Sep 24, 2020
1 parent e856023 commit 8139a02
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/apollo-server-plugin-base/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export {

export interface ApolloServerPlugin<
TContext extends BaseContext = BaseContext
> extends AnyFunctionMap {
> {
serverWillStart?(
service: GraphQLServiceContext,
): ValueOrPromise<GraphQLServerListener | void>;
Expand Down

0 comments on commit 8139a02

Please sign in to comment.