Skip to content

Commit

Permalink
Add correct project references for apollo-server-cloud-functions. (#…
Browse files Browse the repository at this point in the history
…1948)

* Add correct project references for `apollo-server-cloud-functions`.

The `apollo-server-cloud-functions` has been been mis-referenced (or
referenced inconsistently) since its original inception in #1446 when its
package directory was `apollo-server-cloud-function` (singular!) and the
`package.json` referenced the plural form (`apollo-server-cloud-functions`):

724d9ff0#diff-e1d725fd66f7e9ef5251abf0437a09ca

These references have been mostly fixed in the READMEs and supporting
documentation, but the underlying monorepo directory structure has still not
been fixed, which I'm sure contributed to this module being overlooked and
unreferenced in the move to TypeScript project references in #1772.

Additionally, the lack of referencing in the monorepo's TS config has
resulted in it being broken in the most recent 2.2.0 release, as reported by
@pyros2097 and @thetre97 in: #1896 (comment)

This should fix that by properly adding the TypeScript project references.

* Sorting.
  • Loading branch information
abernix authored Nov 12, 2018
1 parent d36eea0 commit b61dee3
Show file tree
Hide file tree
Showing 14 changed files with 12 additions and 0 deletions.
9 changes: 9 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
"apollo-server-cache-memcached": "file:packages/apollo-server-cache-memcached",
"apollo-server-cache-redis": "file:packages/apollo-server-cache-redis",
"apollo-server-caching": "file:packages/apollo-server-caching",
"apollo-server-cloud-functions": "file:packages/apollo-server-cloud-functions",
"apollo-server-cloudflare": "file:packages/apollo-server-cloudflare",
"apollo-server-core": "file:packages/apollo-server-core",
"apollo-server-env": "file:packages/apollo-server-env",
Expand Down
1 change: 1 addition & 0 deletions tsconfig.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
{ "path": "./packages/apollo-server-cache-memcached" },
{ "path": "./packages/apollo-server-cache-redis" },
{ "path": "./packages/apollo-server-caching" },
{ "path": "./packages/apollo-server-cloud-functions" },
{ "path": "./packages/apollo-server-cloudflare" },
{ "path": "./packages/apollo-server-core" },
{ "path": "./packages/apollo-server-errors" },
Expand Down
1 change: 1 addition & 0 deletions tsconfig.test.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
{ "path": "./packages/apollo-server-cache-memcached/src/__tests__/" },
{ "path": "./packages/apollo-server-cache-redis/src/__tests__/" },
{ "path": "./packages/apollo-server-caching/src/__tests__/" },
{ "path": "./packages/apollo-server-cloud-functions/src/__tests__/" },
{ "path": "./packages/apollo-server-core/src/__tests__/" },
{ "path": "./packages/apollo-server-express/src/__tests__/" },
{ "path": "./packages/apollo-server-hapi/src/__tests__/" },
Expand Down

0 comments on commit b61dee3

Please sign in to comment.