Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for __resolveType #13

Closed
rdrey opened this issue May 31, 2016 · 4 comments
Closed

Documentation for __resolveType #13

rdrey opened this issue May 31, 2016 · 4 comments

Comments

@rdrey
Copy link
Contributor

rdrey commented May 31, 2016

I had to read unit tests to figure out how to use __resolveType. 😅
@helfer
Copy link
Contributor

helfer commented May 31, 2016 •
edited
Loading

It's actually in the docs, but I guess it's not easy to find: http://docs.apollostack.com/apollo-server/resolvers.html#addResolveFunctionsToSchema

Maybe we could break it out into a separate subsection under 'addingResolvers'. It could be called 'Interfaces & Unions'. Would you like to make a PR? 😁

@zol zol added 📝 documentation Focuses on changes to the documentation (docs) and removed 📝 documentation Focuses on changes to the documentation (docs) labels May 31, 2016
@rdrey
Copy link
Contributor Author

rdrey commented Jun 1, 2016

Ah thanks, I might 😝

I would like to split docs a little differently. At the moment the Apollo Server page looks like the only page I really need as an apollo-server user and the other pages (GraphQL type language, Adding resolvers, Mocking, ...) look like they just document internal/utility functions.

If they had more generic page titles like "Schema, Resolvers, Mocks, Connectors", we could explain a little more about each parameter (with links to these pages from the Apollo Server parameters), followed by a section with graphql-tools internal functions that are clearly useful for people using these components separately.

@helfer
Copy link
Contributor

helfer commented Jun 1, 2016

Yeah, I agree. What you proposed sounds great to me. If you want, you can go ahead and start renaming them, and make a PR against the server-refactor branch which I've just created as a branch we can work on to make this happen!

@helfer
Copy link
Contributor

helfer commented Jun 1, 2016

Closing this here, we can track it in the docs repo.

@helfer helfer closed this as completed Jun 1, 2016
evans pushed a commit that referenced this issue Jul 3, 2018
@glasser @evans
Update for graphql-extensions@0.1.0 API (#13)
d528a52 
* Upgrade to TypeScript 2.8

* Add tslint and prettier

* Update for graphql-extensions@0.1.0 API

* 0.2.0-beta.0

* Make work with newest API usage

format() now gets called before the requestDidStart() EndHandler.

* 0.2.0-beta.1
evans added a commit that referenced this issue Jul 3, 2018
@evans
Import apollo-tracing-js (#1292)
8496387 
* Initial commit

* 0.0.3

* Replace endOffset with duration in resolver calls

* 0.0.4

* Fix duration

* 0.0.5

* Remove unnecessary schema level resolve function and return schema

* Update README

* 0.0.6

* Update README

* Update dependencies

* 0.0.7

* Update README

* set package.json to point to this repository (#3)

* Update dependencies

Fixes #4.

* 0.0.8

* Add asynciterable support to tsconfig.json

* Skip trace collection when context or context._traceCollector is undefined

Fixes #5.

* 0.0.9

* Rewrite to use graphql-extensions

* 0.0.10

* 0.0.11

* 0.1.0

* Update graphql-extensions dependency and downgrade TS target

* 0.1.1

* Update README

* Update README

* Increase version range for `graphql` peerDependency. (#7)

* 0.1.2

* Update dependencies

* 0.1.3

* [apollo-bot] Update the Issue/PR Templates with auto label (#9)

* Update `graphql` peer dependency range to allow 0.13.x.

* dev: Update TypeScript to latest version, v2.7.2.

* dev: Update jest & dependencies to latest versions.

* dev: Update type definitions for `graphql`, `node` and `jest`.

* Allow `undefined` to return from `format`. (#12)

* Allow `undefined` to return from `format`.

TypeScript 2.7 introduced new "Strict Class Instantiation" rules which,
as the name suggests, require properties which are intended to be set
(eventually, to a type) be set during construction.

Before this change, the `TracingExtension` class was deferred setting these
private properties (namely, `startWallTime`, `endWallTime`, `startHrTime`
and `duration`), but not during instantiation which required setting
marking them as optional and guarding their usage in other methods which
might use those (temporarily `undefined`, if even for a tick) properties.
For example, the expectation that `format` is _only_ called after
`requestDidStart` is not guaranteed with this configuration, even if it is
expected under normal operation.

Therefore, this change adds the additional guarding and updates the `format`
method to return `undefined` in the event that it doesn't have the appropriate
data.

* Update `graphql-extensions` dependency to `~0.0.9`.

Specifically, to take advantage of a type which landed in
`graphql-extensions@0.0.9` thanks to
https://github.com/apollographql/graphql-extensions/pull/10.

* 0.1.4

* Update for graphql-extensions@0.1.0 API (#13)

* Upgrade to TypeScript 2.8

* Add tslint and prettier

* Update for graphql-extensions@0.1.0 API

* 0.2.0-beta.0

* Make work with newest API usage

format() now gets called before the requestDidStart() EndHandler.

* 0.2.0-beta.1

* remove unused files from tracing package

* upgrade packages, fix compilation bugs, and add test
evans pushed a commit that referenced this issue Jul 3, 2018
@evans
[apollo-bot] Update the Issue/PR Templates with auto label (#13)
4ab21a4
evans added a commit that referenced this issue Jul 3, 2018
@evans
Import apollo-cache-control-js (#1294)
19c8adf 
* Initial commit

* Add .npmignore to avoid ignoring lib when publishing

* 0.0.2

* Update graphql-extensions dependency to 0.0.2

* 0.0.3

* Reorganize code and add tests

* 0.0.4

* Add tests and reorganize code

* 0.0.5

* Update dependency to graphql-extensions 0.0.4

* 0.0.6

* Update graphql-extensions dependency and downgrade TS target

* 0.0.7

* Update README

* Update README

* Update README

* Update README

* Add import instructions for TypeScript to README (#7)

* Add cache hints when the directive is defined on interfaces (#10)

* Increase version range for `graphql` peerDependency. (#12)

* 0.0.8

* Update dependencies

* 0.0.9

* [apollo-bot] Update the Issue/PR Templates with auto label (#13)

* [apollo-bot] Update the Templates with docs label (#15)

* Add cache hints to info.cacheControl (#16)

This exposes the `cacheControl` hints on the schema, to the resolvers at runtime.

* Update `graphql` peer dependency range to allow 0.13.x.

* dev: Update TypeScript to latest version, v2.7.2.

* dev: Update jest & dependencies to latest versions.

* dev: Update type definitions for `graphql`, `node` and `jest`.

* dev: Update `graphql` to latest version, v0.13.2.

* 0.0.10

* Add defaultMaxAge option

This is an easy way to quickly say "I want everything in my schema to be cached
for 5 seconds". You can override it with specific maxAges on specific fields or
types.

An upcoming release of apollo-server-* will allow you to specify options to
cacheControl.

* Add CircleCI config

* Add partial CHANGELOG

* 0.1.0

* Honor overwrite default maxAge with maxAge=0 (Fixes #22) (#23)

* 0.1.1

* Allow default caching to apply to interfaces

* remove unused files

* update versions and use a-s style config

* run prettier

* fix tests and typing
trevor-scheer pushed a commit that referenced this issue May 6, 2020
@renovate @abernix
chore(deps): update dependency lint-staged to v8.1.5 (#13)
ae8c589
trevor-scheer pushed a commit that referenced this issue May 14, 2020
@renovate @abernix
chore(deps): update dependency lint-staged to v8.1.5 (#13)
8c22381
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zol @rdrey @helfer