Expose request Object to formatError

[gajus]

I would like to log the request body when an error occurs. This requires access to the request object.

In general, request object often contains additional details that might be desired to be logged, e.g. user session ID.

[gajus]

You can have access to the request if your pass options as a function.

You cannot access it in the formatError function. You can use a factory pattern to create a new formatError on every request, though.

[domarmstrong]

#631

[majelbstoat]

Rebinding the format error function on every request seems very wasteful. Would be great if it took request, or context, or something that exposed this, a second parameter.

(My usecase is stackdriver error reporting, which can make use of requests and formatError is a convenient place to log all graphql errors)

[codyzu]

I have the same requirement as @majelbstoat . When logging and reporting errors, I need to get some info from the request in order to create a relation between the errors and the requester. I am using apollo-server-koa and I am unable to find a way to do this. The apollo-server-koa does not accept a function for the options... so even the workaround does not seem possible.

Has anyone made any progress for this or found work around?

[robrichard]

I also have this requirement. The best workaround I found was to extend ApolloServer from apollo-server-express and overwrite the createGraphQLServerOptions method. Unfortunately, you can't use formatError here either since it doesn't get called (see #1439), but you can access the errors in formatResponse.

class MyApolloServer extends ApolloServer {
    async createGraphQLServerOptions(req) {
        return {
            schema,
            rootValue,
            context,
//          formatError: e => handleError(e, req) // doesn't get called
            formatResponse: graphqlResponse => {
                if (graphqlResponse.errors) {
                    errors = graphqlResponse.errors.map(e => handleError(e, req));
                }
                return { ...graphqlResponse, errors };
            },
        };
    }
}

[vinayuttam]

Is there any update on this? Like others, I also have a requirement to log some information to correlate between events that happen in the request.

[declanelcocks]

A bit of a blocker for me too, since our current server initialisation utilises graphqlExpress to return the formatError option based on the request object. We use it to handle things such as language so upgrading to v2 is looking quite painful.

[ValterSantosMatos]

Also blocker for me. As a very dirty workaround I ended up wrapping all resolvers into a try catch so I could access the context in case of an error, just before passing them to the Apollo server...

static addStorageToContext(resolvers) {
    const keys = Object.keys(resolvers);

    // Recursively translates the errors if they are custom errors
    keys.map((key) => {
      if (typeof resolvers[key] === 'function') {
        const originalResolver = resolvers[key];
        resolvers[key] = (_parent, _input, context: IContext, ...args) => {
          return Promise.resolve(
            originalResolver(_parent, _input, context, ...args),
          ).catch((error) => {
            // Log error...

            throw error;
          });
        };
      } else {
        ConfigApollo.addStorageToContext(resolvers[key]);
      }
    });

    return resolvers;
  }

[fakership]

@robrichard I also meet up with the problem, how to resolve it?

[philsch]

The linked code change above kind of solves the problem, although the context is still not available in the formatError callback. As this was also a repetitive task in my projects, I've created a npm package for it https://github.com/philsch/graphql-error-tracking-extension. I hope it is useful for you, if not you can still use the package code to understand how to use the context extension. You can also read about a real life example at my blog post.

[techwes]

This is blocking my upgrade to 2.0 as well. In 1.0 I used code like this:

graphqlExpress(request => ({
  schema,
  context: request => ({ request }),
  formatError: request => error => {
    // Log Error to Sentry with extra request context
    // If appropriate, change error message to obscure real error
    // from non-admin users.
  }
}))

But now upgrading to 2.0 I see no way to get the request information to add context to my logs. It seems like philsch's code might be a workaround and I also found this example.

Is implementing a custom graphql-extension going to remain the only supported way to accomplish this? Or is there a chance we can get the graphql context passed as a parameter to the formatError function?

[toverux]

I'd very much like to get the request context in formatError. I don't want to use GraphQLExtension#willSendResponse as we can only access GraphQLFormattedError objects here.

I have localizable error objects, and I'd like to localize the error message in formatError based on the Accept-Language header. This is cleaner if I can do that from GraphQLError objects (the ones formatError receives), and avoid manipualting raw objects in willSendResponse, that will be clunky and error-prone.

Should I definitely forget about getting the context in formatError and go for the extension, or is there a chance that this gets fixed?

[twelve17]

@evans , may I ask how #1547 has fixed this issue? I do not see an ability for formatError to access the context or request. Did I miss something, perhaps?

[eladchen]

For anyone stumbling upon this, here's a gist of how to apply @robrichard proposal
(I know this issue closed, but a google search pointed me here).

https://gist.github.com/eladchen/00251cfd96a3fc4fe0c986d83fd48bc2