Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage #62

Closed
helfer opened this issue Jul 28, 2016 · 2 comments
Closed

Test coverage #62

helfer opened this issue Jul 28, 2016 · 2 comments

Comments

@helfer
Copy link
Contributor

helfer commented Jul 28, 2016

We should make sure all significant logic is covered by tests. Right now the line coverage is close to 100%, but it seems some features aren't tested.
@helfer
Copy link
Contributor Author

helfer commented Jul 29, 2016 •
edited
Loading

Options currently not covered by tests:

  • logFunction
  • formatError
  • validationRules
  • rootValue

logFunction can't be tested yet because it doesn't actually do anything as long as logging PR isn't merged in graphql-js (graphql/graphql-js#402)

@helfer
Copy link
Contributor Author

helfer commented Jul 29, 2016 •
edited
Loading

In addition, the following should be done:

  • remove unused resolve functions in tests for OperationStore.
  • test the getMap function in OperationStore
  • test option sanity checks in expressApollo
  • figure out why status code 400 response shows up as not covered in HAPI integration
  • figure out why status codes 400 and 405 show up as not covered in Koa integration

@helfer helfer mentioned this issue Jul 29, 2016
Merged
@helfer helfer closed this as completed Jul 29, 2016
trevor-scheer pushed a commit that referenced this issue May 6, 2020
@renovate
chore(deps): update dependency @types/node-fetch to v2.3.2 (#62)
0d508fd
trevor-scheer pushed a commit that referenced this issue May 14, 2020
@renovate
chore(deps): update dependency @types/node-fetch to v2.3.2 (#62)
6f24897
@snyk-bot snyk-bot mentioned this issue Dec 4, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@helfer