Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: VSCode autocomplete broken for AS4 deep imports #6899

Closed
trevor-scheer opened this issue Sep 12, 2022 · 4 comments · Fixed by #7614
Closed

v4: VSCode autocomplete broken for AS4 deep imports #6899

trevor-scheer opened this issue Sep 12, 2022 · 4 comments · Fixed by #7614

Comments

@trevor-scheer
Copy link
Member

Not sure if this is a misconfiguration of the published package or if it's something that's unsupported by VSCode, needs more investigation. It appears that (through a quick manual test) @apollo/client suffers from the same problem.

@glasser
Copy link
Member

glasser commented Sep 19, 2022

Might be helpful to provide a detailed reproduction recipe.

@trevor-scheer
Copy link
Member Author

  1. Run the following:
mkdir repro && cd repro && npm init -y && npm i @apollo/server && touch index.js
  1. Open repro/index.js in VS Code
code index.js # if you've installed VS Code to your PATH
  1. Start typing ApolloServer and note the autocomplete with suggestion to auto import.
  2. Start typing startStandaloneServer and note that autocomplete doesn't trigger.

The same applies to all deep imports.

@glasser
Copy link
Member

glasser commented Nov 1, 2022

I know this is about an entirely different feature (typeVersions not exports) but this comment might still be relevant maybe: microsoft/TypeScript#43133 (comment)

trevor-scheer pushed a commit that referenced this issue Jun 26, 2023
Fixes #7222
Fixes #6899

Stop removing CommonJS Types and fix `exports` to properly direct to the
right types. This enables consumers to use the `node16` and `nodenext`
`moduleResolution` options in CommonJS projects. Additionally, this fixes
autocompletion for deep imports.
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants