[2.0] Data source enhancements #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 |
glasser
added a commit
to apollographql/datasource-rest
that referenced
this pull request
Dec 3, 2022
Previously, the `url` on the `FetcherResponse` returned from an HTTPCache would be set properly if this was an actual fetch, but set to '' if it were read from the cache. This issue was introduced in apollographql/apollo-server#1362 (as part of the initial creation of RESTDataSource) as part of allowing for custom cache keys. Fixes #35.
glasser
added a commit
to apollographql/datasource-rest
that referenced
this pull request
Dec 5, 2022
Previously, the `url` on the `FetcherResponse` returned from an HTTPCache would be set properly if this was an actual fetch, but set to '' if it were read from the cache. This issue was introduced in apollographql/apollo-server#1362 (as part of the initial creation of RESTDataSource) as part of allowing for custom cache keys. Fixes #35.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances
RESTDataSourcewith support for custom cache keys, overriding of TTLs, and request deduplication.