-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to testing and build infrastructure #1521
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ea0ddf
to
6187d0d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various updates to the testing and build infrastructure.
file:
specifiers, as recommended by the Lerna author. This requires moving alldevDependencies
to the top-level package. The big benefit of this is that hoisting and linking no longer relies onlerna bootstrap
, but uses nativenpm
mechanisms. Among other things, this gives us a consistentpackage-lock.json
for the entire monorepo.npm ci
(which depends onpackage-lock.json
).package-lock.json
checksum and cache the npm cache dir.lerna run test
, we now use a single top-level Jest config. This makes tests run a lot faster, and works really well in combination with file watching.--maxWorkers=2
. It turns out Jest by default uses the number of cores, which is way too much when running in a container, and leads to bad performance and failing tests.tsconfig.json
now enablesstrict
and various related settings. I fixed some typing issues in packages, but for others the localtsconfig.json
overrides these with less strict options for now. But at least the default is strict and we know where the issues are.