Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koa: esInterop compatibility #1579

Closed
wants to merge 2 commits into from

Conversation

ishitatsuyuki
Copy link

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • (not applicable) Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

Close #1393

@apollo-cla
Copy link

@ishitatsuyuki: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@ishitatsuyuki
Copy link
Author

Can someone assign a reviewer?

@hwillson hwillson self-assigned this Sep 20, 2018
@hwillson
Copy link
Member

Thanks for this @ishitatsuyuki. We're changing the esModuleInterop approach for the entire repo, so when #1699 is merged in, the changes in this PR will no longer be necessary. We should have it merged shortly. Thanks for your work on this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants