Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call formatError when passed in options to runQuery, fixes #1439 #1660

Closed
wants to merge 2 commits into from

Conversation

tgriesser
Copy link
Contributor

@tgriesser tgriesser commented Sep 13, 2018

At first I thought my code was so good that there were no errors. On closer inspection, I found the formatError option was being ignored if it's added in the options outside of the ApolloServer constructor (in runHttpQuery), so my logging wasn't being called. I'm not specifying in the constructor because I need to access the request object and this isn't available in the constructor.

This is the cleanest solution I found without changing too much about how the current extension ordering works.

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@ghost ghost added the 🪲 bug label Sep 13, 2018
@tgriesser
Copy link
Contributor Author

Nevermind, based on other tests this needs a different approach.

@tgriesser tgriesser closed this Sep 13, 2018
@tgriesser tgriesser deleted the formatError branch September 13, 2018 14:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant