Call formatError when passed in options to runQuery, fixes #1439 #1660
+58
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I thought my code was so good that there were no errors. On closer inspection, I found the
formatError
option was being ignored if it's added in theoptions
outside of theApolloServer
constructor (inrunHttpQuery
), so my logging wasn't being called. I'm not specifying in the constructor because I need to access therequest
object and this isn't available in the constructor.This is the cleanest solution I found without changing too much about how the current extension ordering works.