Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with Adonis Framework #1937

Closed
wants to merge 5 commits into from
Closed

Integration with Adonis Framework #1937

wants to merge 5 commits into from

Conversation

enniel
Copy link
Contributor

@enniel enniel commented Nov 8, 2018

No description provided.

@footniko
Copy link

When to expect it to be merged?

@otang
Copy link

otang commented Jan 25, 2019

Following this. Nice work!

@geoffreylzf
Copy link

Hi, want to ask when this will be merge?

@okurichenko
Copy link

👍solve conflicts and merge?

@giuseppeangri
Copy link

Hi, there are news about the merge?

@abernix
Copy link
Member

abernix commented Jul 8, 2019

While I really appreciate you taking the time to open this PR, unfortunately, the Adonis framework hasn't been popular enough of a request for us to adopt into the Apollo Server repository along with the, for lack of a better word, maintenance burden that goes along with taking on another framework.

We currently support many frameworks and do our best to maintain them while maintaining feature parity across them. We encourage developers who are using different frameworks to to publish their own packages, and we intend on adopting a more simple approach to supporting this in Apollo Server 3 (#2360) that we hope facilitates this. I hope it's clear that your work here isn't in vain though, and that this implementation could easily exist as it's own package that leverages apollo-server-core, despite us not accepting this into core.

@abernix abernix closed this Jul 8, 2019
@ghosh
Copy link

ghosh commented Jul 11, 2019

@enniel While its a bummer that it could not be added to the official repo, the reasons are understandable.

Would you be open to publishing this as a stand alone package? I'm sure the adonis community would be quite grateful for it.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants