Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): update dependency ws to v6.1.1" #2006

Merged
merged 1 commit into from
Nov 21, 2018

Conversation

abernix
Copy link
Member

@abernix abernix commented Nov 21, 2018

Reverts #1987

In diagnosing the problem exhibited on the CircleCI run for #2005, the problem bisected back to this commit which updated the ws types to a new patch version:

$ git bisect start master @{10.days.ago}
$ git bisect run sh -c 'npm run clean; npm i; npm i --no-save typescript@rc; npm t; sleep 5;'

The npm i --no-save typescript@rc is necessary to fix the now-broken nightly typescript@next version which had been in place at the time — which is what #2005 aimed to fix.

yielded:

bde56a6c76678292d7c6c32b849c07f8da9a6725 is the first bad commit
commit bde56a6c76678292d7c6c32b849c07f8da9a6725
Author: renovate[bot] <renovate[bot]@users.noreply.github.com>
Date:   Sat Nov 17 13:34:58 2018 +0000

    chore(deps): update dependency ws to v6.1.1 (#1987)

I haven't looked into it in more detail, but reverting this update does seem to resolve the problem. We'll likely have to revisit this soon, but this will hopefully unblock the barrage of PRs which are currently failing because of the TypeScript error demonstrated in #2005.

@abernix abernix self-assigned this Nov 21, 2018
@abernix abernix merged commit 344fde9 into master Nov 21, 2018
@abernix abernix deleted the revert-1987-renovate/ws-6.x branch December 3, 2018 12:23
abernix added a commit that referenced this pull request Dec 13, 2018
…eq false.

This fixes a TypeScript `TypeError` which was encountered after the
`@types/ws` typings were updated[[1]] to more correctly identify valid URLs.

The error exhibited on CI[[2] was:

TypeError [ERR_INVALID_URL]: Invalid URL: ws://localhost:6666undefined

This had been previously reverted[[3]] but was auto-merged again for a
reason I don't quite have time to investigate right now, though I suspect
it's something I'll be able to prevent in the future with a bit more care.

[1]: #1992
[2]: https://circleci.com/gh/apollographql/apollo-server/22416
[3]: #2006

cc @martijnwalraven
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants