Type parameters for context function separately from the context it produces #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```context?: ContextFunction<ExpressContext, any> | Context<any>;``` is ```context?: ContextFunction<ExpressContext, any> | any;``` which is ```context?: any;``` microsoft/TypeScript#18568 Since the ContextFunction<...> part is ignored, no type hinting will be provided when a function is passed to `context`. We don't really mean `any`, we mean an object with any shape, so we should use `object` instead
abernix
approved these changes
Feb 21, 2019
| @@ -24,6 +24,51 @@ describe('apollo-server', () => { | |||
| it('accepts typeDefs and mocks', () => { | |||
| expect(() => new ApolloServer({ typeDefs, mocks: true })).not.toThrow; | |||
| }); | |||
|
|
|||
| describe('context field', () => { | |||
There was a problem hiding this comment.
These tests are a super welcome addition. Though I suspect we should put most of these in apollo-server-integration-testsuite to make sure they are exercised on each of the integration flavors (e.g. hapi, express, etc.), possibly alongside the existing constructor tests:
There was a problem hiding this comment.
To be clear, I think this can be a follow-up PR. ^
4 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #2346 , this PR fixes the problem introduced by #2330 and should be solve the problem brought up in #1593
The two significant changes are
apollo-server/packages/apollo-server-core/src/types.ts
Lines 33 to 35 in d08569e
reqand, but the resulting context doesn't need to contain (or only contain)req)anytoobjectapollo-server/packages/apollo-server-core/src/types.ts
Line 32 in d08569e
TODO: