Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apollo-server-plugin-base] fix GraphQLRequestListener type definitions #2368

Merged
merged 4 commits into from
Jun 30, 2019

Conversation

doomsower
Copy link
Contributor

@doomsower doomsower commented Feb 24, 2019

This makes typescript compiler happy when listers return void:

export class SomeListener implements GraphQLRequestListener {
  parsingDidStart() {
    console.log('parsingDidStart');
  }
}

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abernix abernix merged commit bf0cd6b into apollographql:master Jun 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants