Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apollo package dependencies #2602

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

trevor-scheer
Copy link
Member

Using the current versions of these dependencies rather than the alphas (from an alpha branch of the server repo) is causing multiple versions of some of these dependencies to appear in our platform repo's release-federation branch. I'm not certain this is the actual problem, but I do feel it brings us one step closer to resolving it.

The error we're seeing in CI looks something like this, which leads me to suspect apollo-env (and other non-alpha apollo- packages):

Trevors-MacBook-Pro-2:apollo-platform-commercial trevorscheer$ npm run clean && npm ci

> apollo-platform-commercial-monorepo@ clean /Users/trevorscheer/Desktop/Repos/apollo-platform-commercial
> git clean -dfqX -- ./node_modules **/{dist,node_modules}/ ./packages/*/tsconfig.tsbuildinfo

npm WARN tar ENOENT: no such file or directory, open '/Users/trevorscheer/Desktop/Repos/apollo-platform-commercial/node_modules/apollo-federation/node_modules/apollo-env/package.json'
npm WARN tar ENOENT: no such file or directory, open '/Users/trevorscheer/Desktop/Repos/apollo-platform-commercial/node_modules/apollo-federation/node_modules/node-fetch/lib/index.mjs'
npm ERR! path /Users/trevorscheer/Desktop/Repos/apollo-platform-commercial/node_modules/apollo-gateway/node_modules/apollo-federation/node_modules/core-js
npm ERR! code ENOTEMPTY
npm ERR! errno -66
npm ERR! syscall rmdir
npm ERR! ENOTEMPTY: directory not empty, rmdir '/Users/trevorscheer/Desktop/Repos/apollo-platform-commercial/node_modules/apollo-gateway/node_modules/apollo-federation/node_modules/core-js'

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/trevorscheer/.npm/_logs/2019-04-24T18_56_18_598Z-debug.log

npm ls apollo-env shows multiple versions in use (and possibly some bad de-duping?) I'm not sure why the deps aren't being met in some places.

Trevors-MacBook-Pro-2:apollo-platform-commercial trevorscheer$ npm ls apollo-env
apollo-platform-commercial-monorepo@ /Users/trevorscheer/Desktop/Repos/apollo-platform-commercial
├─┬ apollo-federation@0.1.0-alpha.7 -> /Users/trevorscheer/Desktop/Repos/apollo-platform-commercial/packages/apollo-federation
│ ├── apollo-env@0.4.1-alpha.1 
│ └─┬ apollo-graphql@0.2.1-alpha.1
│   └── apollo-env@0.4.1-alpha.1  deduped
├─┬ apollo-gateway@0.1.0-alpha.3 -> /Users/trevorscheer/Desktop/Repos/apollo-platform-commercial/packages/apollo-gateway
│ ├── apollo-env@0.4.1-alpha.1 
│ ├─┬ UNMET DEPENDENCY apollo-federation@file:packages/apollo-federation
│ │ ├── UNMET DEPENDENCY apollo-env@0.4.1-alpha.1 
│ │ └─┬ UNMET DEPENDENCY apollo-graphql@0.2.1-alpha.1
│ │   └── UNMET DEPENDENCY apollo-env@0.4.1-alpha.1 
│ ├─┬ apollo-graphql@0.2.1-alpha.1
│ │ └── apollo-env@0.4.1-alpha.1  deduped
│ └─┬ apollo-server-express@2.5.0-alpha.6
│   └─┬ apollo-server-core@2.5.0-alpha.6
│     ├─┬ @apollographql/apollo-tools@0.3.5
│     │ └── apollo-env@0.4.0 
│     └─┬ apollo-engine-reporting@1.1.0-alpha.6
│       └─┬ apollo-graphql@0.2.0
│         └── apollo-env@0.4.0 
├─┬ apollo-server-core@2.5.0-alpha.6
│ ├─┬ @apollographql/apollo-tools@0.3.5
│ │ └── apollo-env@0.4.0 
│ └─┬ apollo-engine-reporting@1.1.0-alpha.6
│   └─┬ apollo-graphql@0.2.0
│     └── apollo-env@0.4.0 
└─┬ apollo-server-plugin-operation-registry@0.1.0-alpha.2 -> /Users/trevorscheer/Desktop/Repos/apollo-platform-commercial/packages/apollo-server-plugin-operation-registry
  └─┬ apollo-graphql@0.2.1-alpha.1
    └── apollo-env@0.4.1-alpha.1 

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@abernix abernix merged commit 83d9e49 into release-2.5.0 Apr 25, 2019
@abernix abernix deleted the trevor/update-alpha-apollo-deps branch April 25, 2019 17:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants