Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Headers bug in IE11 #2607

Merged
merged 3 commits into from
Apr 25, 2019
Merged

Conversation

Multiply
Copy link
Contributor

@Multiply Multiply commented Apr 25, 2019

When calling new Headers(undefined) in IE11 an Invalid argument exception is thrown.
With this in place, we'll call it with an empty object, resulting in an empty Headers object.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

Edit:

I mistakenly wrote null, where I meant to write undefined.

@Multiply
Copy link
Contributor Author

Multiply commented Apr 25, 2019

I haven't added tests for this, as I am unsure if you've got any IE11 targets in your test suites.

Edit:
This also affects Edge, it seems.

In IE11, it's running using the default polyfills.

@Multiply Multiply force-pushed the fix-ie11-headers-bug branch from c8714cf to 78825c6 Compare April 25, 2019 13:51
When calling `new Headers(undefined)` in IE11 an `Invalid argument` exception is thrown.
With this in place, we'll call it with an empty object, resulting in an empty Headers object.
@Multiply Multiply force-pushed the fix-ie11-headers-bug branch from 78825c6 to df5d8f4 Compare April 25, 2019 13:54
@abernix abernix merged commit 0b602fd into apollographql:master Apr 25, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants