Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use one central typescript configuration #281

Merged
merged 3 commits into from
Jan 26, 2017
Merged

Use one central typescript configuration #281

merged 3 commits into from
Jan 26, 2017

Conversation

kamilkisiela
Copy link
Contributor

No description provided.

@DxCx
Copy link
Contributor

DxCx commented Jan 25, 2017

Thanks!
Why not sharing types root as well?

@kamilkisiela
Copy link
Contributor Author

@DxCx I think every path that is defined in each config, is relative to that config's directory.

It means that if I put typesRoot in the central config, it won't see those @types/* in each packages/*/node_modules/@types/.

@DxCx
Copy link
Contributor

DxCx commented Jan 26, 2017

Alright thanks!

@DxCx DxCx merged commit a36bd49 into master Jan 26, 2017
@kamilkisiela kamilkisiela deleted the central-tsconfig branch January 26, 2017 13:31
@DxCx DxCx mentioned this pull request Jan 29, 2017
Merged
4 tasks
trevor-scheer pushed a commit that referenced this pull request May 6, 2020
@renovate
chore(deps): update dependency codecov to v3.6.4 (#281)
1a8dc84
trevor-scheer pushed a commit that referenced this pull request May 14, 2020
@renovate
chore(deps): update dependency codecov to v3.6.4 (#281)
efe0745
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamilkisiela @DxCx @helfer