Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade hapi package #3273

Closed
wants to merge 6 commits into from
Closed

Upgrade hapi package #3273

wants to merge 6 commits into from

Conversation

swashcap
Copy link
Contributor

  • Type: Integration (upgrade a supported framework)
  • Problem:
    • Apollo-server is 1 major version behind on hapi (current is v18)
    • The hapi 17 license requires users purchase a commercial license (ref: https://blog.sideway.com/hapi-enterprise-support-22aa77a8158e). While the version currently used to test hapi in this repository (hapi@17.8.5) doesn't contain this license, a renovate upgrade may unwittingly put this project in a licensing issue. Also, Apollo users should probably upgrade if they want to avoid the commercial license and keep up with the latest and greatest stuff. The package rename makes this difficult.
  • Solution:
    • Upgrade apollo-server-hapi to the @hapi/hapi packages
    • Update documentation, comments
    • Add @hapi/hapi as an explicit peer dependency in apollo-server-hapi
  • Testing: Let's see if CI tests pass 🤞

@swashcap swashcap mentioned this pull request Sep 24, 2019
Closed
@timcosta
Copy link

Just wanted to highlight that hapi does not require a commercial license for use at any version. A commercial license is available and entitles you to additional support and security patches for versions that are no longer being actively maintained. Even if you were to use a super old version, you do not need a commercial license.

The license you linked to is for @commercial/hapi, not for @hapi/hapi which is governed by https://github.com/hapijs/hapi/blob/master/LICENSE.md.

@salzhrani
Copy link

Can someone add this to the v3 milestone?

@sahellebusch
Copy link

Any news on this? Anything we can do to help? I'm currently in need of this update in order to move forward.

@robmcguinness
Copy link

@sahellebusch have you tried using alias feature in yarn or npm?

"hapi": "npm:@hapi/hapi@19.x.x"

@aliwatters
Copy link

@StephenBarlow - would be awesome to see this PR accepted, anything that we can do to help?

@abernix abernix added this to the Release 3.x milestone Apr 24, 2020
@abernix abernix removed the request for review from StephenBarlow April 24, 2020 10:16
@abernix abernix added the 🍳 breaking-change Needs to wait for a major release. label Apr 24, 2020
@abernix abernix mentioned this pull request Apr 24, 2020
Closed
@abernix abernix closed this Jun 24, 2020
@ConAntonakos
Copy link

@abernix This looks related to the unintentional closing from #4304?

@abernix
Copy link
Member

abernix commented Jun 24, 2020

Yup; there are a bunch affected. Apologies for the confusion. I will get this sorted out, but I'm not manually re-opening these until GitHub support can assess what happened behind-the-scenes. I will manually (or semi-automatically) re-open them depending on the results of that assessment from them.

@abernix abernix reopened this Jun 25, 2020
@abernix abernix changed the base branch from master to main June 25, 2020 09:04
@glasser glasser mentioned this pull request Apr 28, 2021
Merged
@glasser
Copy link
Member

glasser commented Apr 29, 2021

While there's an upgrade already on release-3.0, we should upgrade again to 20.1.2 which is required for Node 16 compat

glasser added a commit that referenced this pull request Apr 30, 2021
@glasser
Update Hapi to 20.1.2
48e5239 
This is the latest release, and the only release that supports Node 16, so it
will be the minimum version that we test again.

Also:
- Update `@types/hapi__hapi` to latest version. Note that you can import from
  `@hapi/hapi` successfully so adjust an import.
- Update `accept` and `boom` to their latest versions, which now have `@hapi/`
  prefix; this includes in apollo-server-micro for some reason.
- release-3.0 couldn't run tests after the last merge from main until this
  change was made; this revealed a failing test of a newly merged feature due to
  a change in a graphql-js error message. Fix that.

This incorporates suggestions from #3273, #3441, and #4254.
@glasser glasser mentioned this pull request Apr 30, 2021
Merged
@glasser
Copy link
Member

glasser commented Apr 30, 2021

This is now fixed on the release-3.0 branch via #5150. I incorporated parts of your PR into it. Thanks!

@glasser glasser closed this Apr 30, 2021
glasser added a commit that referenced this pull request Apr 30, 2021
@glasser
Update Hapi to 20.1.2 (#5150)
05e3667 
This is the latest release, and the only release that supports Node 16, so it
will be the minimum version that we test again.

Also:
- Update `@types/hapi__hapi` to latest version. Note that you can import from
  `@hapi/hapi` successfully so adjust an import.
- Update `accept` and `boom` to their latest versions, which now have `@hapi/`
  prefix; this includes in apollo-server-micro for some reason.
- release-3.0 couldn't run tests after the last merge from main until this
  change was made; this revealed a failing test of a newly merged feature due to
  a change in a graphql-js error message. Fix that.

This incorporates suggestions from #3273, #3441, and #4254.
@glasser glasser removed this from the Release 3.x milestone Jun 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
🍳 breaking-change Needs to wait for a major release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@swashcap @timcosta @salzhrani @sahellebusch @robmcguinness @aliwatters @ConAntonakos @abernix @glasser