Preserve the extensions property when pre-execution errors occur.
#3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, any `extensions` that are present on the `response` are not returned to the client when an error occurs in pre-execution stages, despite the fact that `extensions` are a perfectly acceptable property to be present when pre-execution errors occur[1]. (Note that `data` is not!) For example, if a user had added their own `extensions` property in the `willSendResponse` hook of a request pipeline API, it would have been removed by the previous implementation of `throwHttpGraphQLError` which did not receive, or accept `extensions`, since it explicitly only passed the `errors` property. This will all be greatly improved when we abstract this transport out! [1]: https://graphql.github.io/graphql-spec/June2018/#sec-Response-Format
trevor-scheer
approved these changes
Oct 9, 2019
abernix
deleted the
abernix/preserve-user-response-extensions-in-pre-execution-errors
branch
mkai
added a commit
to spring-media/themis-graphql
that referenced
this pull request
Feb 17, 2020
mkai
added a commit
to spring-media/themis-graphql
that referenced
this pull request
Feb 18, 2020
* Update dev dependencies * Update dependencies (minor and patch updates) * Adjust test assertion to account for Apollo Server bugfix apollographql/apollo-server#3394 * Prepend ./ if needed when loading local strategy file This is required due to changed behaviour in `require.resolve` in Node 12. * Update dependencies (major releases) * Migrate to mkdirp v1.0 Promise API * Migrate to @hapi/joi v15 Postponing the upgrade to the latest version until the new extensions API (breaking change) is properly documented (hapijs/joi#2011). * Bump version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, any
extensionsthat are present on theresponseare not returned to the client when an error occurs in pre-execution stages, despite the fact thatextensionsare a perfectly acceptable property to be present when pre-execution errors occur1. (Note thatdatais not!)For example, if a user had added their own
extensionsproperty in thewillSendResponsehook of a request pipeline API, it would have been removed by the previous implementation ofthrowHttpGraphQLErrorwhich did not receive, or acceptextensions, since it explicitly only passed theerrorsproperty.This will all be greatly improved when we abstract this transport out!