Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sampleRate option to limit data volume #3681

Closed
wants to merge 1 commit into from

Conversation

jhp
Copy link

@jhp jhp commented Jan 16, 2020

Limit the addition of traces to engine reports by random sampling.

This is intended to support Glassdoor's use of Apollo server.

@apollo-cla
Copy link

@jhp: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@abernix abernix closed this Jun 24, 2020
@abernix abernix reopened this Jun 25, 2020
@abernix abernix changed the base branch from master to main June 25, 2020 09:03
@glasser
Copy link
Member

glasser commented Oct 7, 2022

Since this PR was opened we've improved usage reporting in several ways such as via the includeReport hook (originally reportTiming) which is very similar to this PR, the ability to aggregate statistics about operations, and to disable field-level instrumentation on a per-operation level. Those improvements should provide outcomes similar or superior to this PR. Sorry for the delay!

@glasser glasser closed this Oct 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants