schema-reporting: Throw if gateway or federated service #4246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsegaran
suggested changes
Jun 15, 2020
| @@ -314,6 +314,16 @@ export class ApolloServerBase { | |||
| // Don't add the extension here (we want to add it later in generateSchemaDerivedData). | |||
| } | |||
|
|
|||
| if (gateway && typeof engine === 'object' && engine.experimental_schemaReporting) { | |||
There was a problem hiding this comment.
This doesn't include the case where someone uses the environment variable. I think it would be less brittle if we make schemaReporting boolean public on the agent, and then check if that is true.
sachindshinde
force-pushed
the
sachin/throw-in-schema-reporting-if-federated
branch
3 times, most recently
from
85274ca to
f5a36fe
Compare
jsegaran
approved these changes
Jun 15, 2020
sachindshinde
force-pushed
the
sachin/throw-in-schema-reporting-if-federated
branch
from
f5a36fe to
82c36ca
Compare
trevor-scheer
added a commit
that referenced
this pull request
Jun 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code to Apollo Server that throws if schema-reporting is enabled for the gateway or for a graph that looks like a federated service.