Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken graphiql endpoint #447

Merged
merged 1 commit into from
Jul 3, 2017

Conversation

mike-marcacci
Copy link
Contributor

@mike-marcacci mike-marcacci commented Jul 1, 2017

It looks like a recent change broke the graphiql endpoint by no longer returning the promise.

It looks like be01aee broke the graphiql endpoint by no longer returning the promise.
@apollo-cla
Copy link

@mike-marcacci: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Copy link
Contributor

@DxCx DxCx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
i assume this fixes #439, because now koa should wait for the promise to resolve before sending it's own headers right?

@stubailo
Copy link
Contributor

stubailo commented Jul 3, 2017

Awesome!

@stubailo stubailo merged commit 0e04139 into apollographql:master Jul 3, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants