Using await on graphiql handler - Fix graphiql issues #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bwlt: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
LGTM |
DxCx
reviewed
Jul 12, 2017
| const query = req.url && url.parse(req.url, true).query || {}; | ||
| GraphiQL.resolveGraphiQLString(query, options, req).then(graphiqlString => { |
There was a problem hiding this comment.
i think eaiser solution is just return the promise here..
There was a problem hiding this comment.
ahah yeah it was so simple!
This reverts commit cbb7be9.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #449 without workarounds on microrouter definitions.
This is a proposal! Please review the code before merging! (It's my first experience with typescript, maybe also the README must be reviewed)
I was not able to provide tests for this use case, but the diff consists on a refactor to the graphiql handler. It use an async function so the microroute awaits the execution of the handler before responds with a 404