A few small follow-up changes from v2.18.0 #4591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasser
force-pushed
the
glasser/v2.18.0-followup
branch
from
22026ca to
40b4d51
Compare
This `extends` declaration was added during the development of v2.18.0 for reasons that turned out to be unnecessary. The declaration makes some valid plugin implementation no longer type-check, so I'm removing it. Fixes #4585.
This one usage-reporting option was hidden in the middle of a bunch of schema-reporting options so I missed it in the handling of legacy options.
This error generally should arise when people try to use the unexported AS 1.x API instead of the 2.x API. (If we find other cases that trigger this error we can update the linked issue.) Fixes #4588.
glasser
force-pushed
the
glasser/v2.18.0-followup
branch
from
40b4d51 to
8492f62
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review individual commits.