Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onHealthCheck for lambda failing to correctly handle returned promise #4969

Merged
merged 5 commits into from
Mar 1, 2021

Commits on Feb 26, 2021

  1. Ensure lambda healthcheck callback waits on returned promise

    This fixes the issue "Custom onHealthCheck function is intermittently called" reported at apollographql#3999.
    This fix ensures the healthcheck handling code does not carry on executing and waits for the returned promise to be resolved or rejected.
    uehondor committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    51d8eed View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2021

  1. Add new tests to exercise lambda healthcheck

    The tests validates that a healthcheck endpoint exists and correctly handles promises returned from the callback.
    
    This commit also moves the 'mock server'-like code (responsible for transforming lambda response into HTTP response) has been moved to a common location where it is reused in the newly created apollo-server-lambda/src/ApolloServer.test.ts.
    uehondor committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    f2b6069 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ddcd266 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2021

  1. Configuration menu
    Copy the full SHA
    5d71c11 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Configuration menu
    Copy the full SHA
    fe71c90 View commit details
    Browse the repository at this point in the history